OSD600 Lab 1

 How did you go about finding someone to work with?

I put up a message on Slack and got a reply from someone, I sent them my contact info and we revied each others code.

What was it like testing and reviewing someone else's code? Did you run into any problems? Did anything surprise you?

At first, it was a little intimidating because I have never done something like this before, but after trying it, it was not as bad as I thought it would be. It's funny how a lot of times we are scared to do something but once we do it we realize we were scared for nothing. One minor problem I had was after I ran npm install to download the node modules I have to update some of them but after that, it worked great! There was nothing that surprised me.

What was it like having someone test and review your code? Were you surprised by anything?

Having someone review and test my code is a very good feeling because you know no matter what happens during the review, you will benefit from it. Two sets of eyes are better then one so even if the person can't find anything wrong you can use their feedback as confirmation your code works well. There was not anything that surprised me.

What kind of issues came up in your testing and review?

Minor errors in regards to documenting code and what I put in the readMe file.

Provide links to issues you filed, and discuss what you found

https://github.com/fluentinstroll/Link-Checker/issues/1

Needed to make the readMe file more clear/specific

https://github.com/fluentinstroll/Link-Checker/issues/2

Modify the file structure of the project to make it more organized.

https://github.com/fluentinstroll/Link-Checker/issues/3

Do not include node_modules when committing

https://github.com/fluentinstroll/Link-Checker/issues/4

Specify what each library is for in the readMe

Provide links to issues that were filed on your repo, and what they were about

https://github.com/joey2031/OSD600-Release0.1/issues/2

ReadMe was not clear enough

https://github.com/joey2031/OSD600-Release0.1/issues/3

Confirmed I did the correct version arguments

https://github.com/joey2031/OSD600-Release0.1/issues/4

Did not need to include node_modules when committing

Were you able to fix all your issues? What was that like?

I was not able to fix the node_modules issue. This was a bit frustrating but I understand I am still learning and it takes time. I am also aware open source encourages collaboration so if I am not able to fix something there is a possibility someone else my sees my code and provide a fix. The same goes for everyone else, someone may have a bug that they can't fix I may be able to fix for them.

 





Comments

Post a Comment

Popular posts from this blog

OSD600 Release 0.4 Part 3

Image
 This is the last blog for OSD600 and the last part of release 0.4! I am excited to be writing this as after this I will be done with everything I need to do for my classes this semester, and graduate! One issue I noticed while working on this is I did not fully understand what was needed to "port" a component from Gatsby to Next. At first, I thought everything you needed to do to port a component was in this migration guide  posted in the issue . After talking to some people on Slack I learned we must not only follow the migration guide but also convert the JavaScript code in the components to TypeScript. I have worked with Typescript before so I had an idea of how it works/what it is (it's basically JavaScript with types), but I never knew how to convert JavaScript code to TypeScript code. After doing some research I learned this process can be broken down into two simple steps: 1. Change all the .jsx files to .tsx files. 2. Add types to all the variables made. Eg. func
Read more

OSD600 Lab 5

Image
 This week we learned about rebasing in Git! Rebasing is basically taking multiple commits and "grouping" or "moving" them into one commit. Before I started the lab I did the walkthrough on the OSD600 GitHub Wiki. At first, I struggled with it (kept getting errors when running git rebase master -i). Then I decided to start over again and I noticed the first time I forgot to commit some files on the refactor branch. I am happy I did this first because it made the lab go very smoothly.  Before I started the lab I took a look at my code and wrote down the improvements I was planning to make. I decided to do these 3 things: change my regular expression variable from a let to a const, remove an array I never used, and update some functions to use the ES6 arrow syntax. It's been a while since I used arrow functions so I used this resource to guide me Every time I added and tested a feature I did a git commit. One improvement that caused an error was when I updated som
Read more

Release 0.3 PR2

Image
  For release 3 we have to make 2 PR's. The first one must be for the  Telesope project  and the second one must be for an external project. These PR's must "build up" from the PR's we did for release 0.2. This blog post will highlight working on the PR for Telescope. When I started this the first place I went was to the issues page on the Telescope repository. I saw there were some tests that needed to be written and were interested in taking on one of these issues. These were more complex than the test I wrote for the first part of 0.3 so  I saw it as a good opportunity to improve my skill. I asked in Slack for some advice on what to do and was given this idea from David: This seemed like a good test to write (challenging but something I can figure out) so I made an issue for it and started working! When I first wrote the test everything looked fine but it kept on failing. At first, I thought that's good, if we pass an invalid date shouldn't the test fa
Read more