OSD600 Release 0.2 PR 2

I started searching for my second pull request on the Hacktoberfest website. As I was looking I found this repository. This was a collection of algorithms written in various programming languages. I have not done much work with algorithms and for this PR and I was hoping to do something with C++ so this seemed like a perfect issue. I worked on this issue, which was to add any algorithm in any language not currently present. At first, my plan was to do bubble sort since I learned that at Seneca and had a good understanding of how it worked. But, someone already did that. At first, I started freaking out because I didn't know any other algorithms. So then I took a deep breath and started doing some research. Eventually, I came across an algorithm called CocktailSort. This seemed like it was a good algorithm to try since I didn't know how it worked, I never studied an algorithm like that, it was more challenging then bubble sort, and was not present in the C++/Sorting directory of the repository. I first let the owner know I will start working on CocktailSort in C++. Then I started coding. After reading some articles, studying the code, and writing it out, it wasn't so bad! I then created and pull requested and waited. The one error I made was I named the file wrong. I named it CocktailSort.cpp, and the maintainers wanted it named cocktail_sort.cpp

I then proceeded to fix that, and my code got merged! This was a really good experience since this made me go out of my comfort zone. I also got to learn a new algorithm because of it! Next time I will try to not be so scared and do some research before making a decision on something. I really enjoyed this pull request and can't wait for the next one!


Comments

Post a Comment

Popular posts from this blog

OSD600 Intro Post

Introduction: Hello, my name is Joey and I am a student at Seneca studying Computer Programming. My whole life I have always been interested in technology. Towards the end of high school, I enrolled in Computer Science and enjoyed the subject. My passion for technology and love of code persuaded me to get an education in Computer Programming. Why Are You Taking this Class? I am taking this class to help widen my skill set and also because I have always been interested in Open Source. I know many programming technologies such as Java, C++ and SQL but I don't know anything about Open Source. It has been a goal of mine to learn but never had the time to look into it. Therefore, I decided to take this class as I believe this is one of the best opportunities to learn!  What is it About Open Source that Attracted You? The freedom the comes with it. I am fascinated by the idea that anyone can take my code and work with it, and I can do the same to theirs. I believe the more people that co...
Read more

Git Workflow When Contributing to Open Source

The following are the steps/workflow you follow when you find a repository on GitHub and wish to contribute to it.      When you find an issue you wish to work on in a  repository , first fork it to your GitHub, then clone it and make a new branch (you will be working off this new branch. Its a good idea to name the branch after the issue you are planning to fix Eg. issue-2) . When you are done with your code push it to the new branch you made for the issue/feature then create a pull request ( pull request is a review request You are asking someone to check the changes on a branch before merging into another branch. ) The person who owns the code will check your code and if it's approved it will get merged with the original. 
Read more

Release 0.3 PR2

Image
  For release 3 we have to make 2 PR's. The first one must be for the  Telesope project  and the second one must be for an external project. These PR's must "build up" from the PR's we did for release 0.2. This blog post will highlight working on the PR for Telescope. When I started this the first place I went was to the issues page on the Telescope repository. I saw there were some tests that needed to be written and were interested in taking on one of these issues. These were more complex than the test I wrote for the first part of 0.3 so  I saw it as a good opportunity to improve my skill. I asked in Slack for some advice on what to do and was given this idea from David: This seemed like a good test to write (challenging but something I can figure out) so I made an issue for it and started working! When I first wrote the test everything looked fine but it kept on failing. At first, I thought that's good, if we pass an invalid date shouldn't the test fa...
Read more