OSD600 Release 0.2 PR 2

I started searching for my second pull request on the Hacktoberfest website. As I was looking I found this repository. This was a collection of algorithms written in various programming languages. I have not done much work with algorithms and for this PR and I was hoping to do something with C++ so this seemed like a perfect issue. I worked on this issue, which was to add any algorithm in any language not currently present. At first, my plan was to do bubble sort since I learned that at Seneca and had a good understanding of how it worked. But, someone already did that. At first, I started freaking out because I didn't know any other algorithms. So then I took a deep breath and started doing some research. Eventually, I came across an algorithm called CocktailSort. This seemed like it was a good algorithm to try since I didn't know how it worked, I never studied an algorithm like that, it was more challenging then bubble sort, and was not present in the C++/Sorting directory of the repository. I first let the owner know I will start working on CocktailSort in C++. Then I started coding. After reading some articles, studying the code, and writing it out, it wasn't so bad! I then created and pull requested and waited. The one error I made was I named the file wrong. I named it CocktailSort.cpp, and the maintainers wanted it named cocktail_sort.cpp

I then proceeded to fix that, and my code got merged! This was a really good experience since this made me go out of my comfort zone. I also got to learn a new algorithm because of it! Next time I will try to not be so scared and do some research before making a decision on something. I really enjoyed this pull request and can't wait for the next one!


Comments

Post a Comment

Popular posts from this blog

OSD600 Release 0.4 Part 3

Image
 This is the last blog for OSD600 and the last part of release 0.4! I am excited to be writing this as after this I will be done with everything I need to do for my classes this semester, and graduate! One issue I noticed while working on this is I did not fully understand what was needed to "port" a component from Gatsby to Next. At first, I thought everything you needed to do to port a component was in this migration guide  posted in the issue . After talking to some people on Slack I learned we must not only follow the migration guide but also convert the JavaScript code in the components to TypeScript. I have worked with Typescript before so I had an idea of how it works/what it is (it's basically JavaScript with types), but I never knew how to convert JavaScript code to TypeScript code. After doing some research I learned this process can be broken down into two simple steps: 1. Change all the .jsx files to .tsx files. 2. Add types to all the variables made. Eg. func
Read more

OSD600 Lab 5

Image
 This week we learned about rebasing in Git! Rebasing is basically taking multiple commits and "grouping" or "moving" them into one commit. Before I started the lab I did the walkthrough on the OSD600 GitHub Wiki. At first, I struggled with it (kept getting errors when running git rebase master -i). Then I decided to start over again and I noticed the first time I forgot to commit some files on the refactor branch. I am happy I did this first because it made the lab go very smoothly.  Before I started the lab I took a look at my code and wrote down the improvements I was planning to make. I decided to do these 3 things: change my regular expression variable from a let to a const, remove an array I never used, and update some functions to use the ES6 arrow syntax. It's been a while since I used arrow functions so I used this resource to guide me Every time I added and tested a feature I did a git commit. One improvement that caused an error was when I updated som
Read more

Release 0.3 PR2

Image
  For release 3 we have to make 2 PR's. The first one must be for the  Telesope project  and the second one must be for an external project. These PR's must "build up" from the PR's we did for release 0.2. This blog post will highlight working on the PR for Telescope. When I started this the first place I went was to the issues page on the Telescope repository. I saw there were some tests that needed to be written and were interested in taking on one of these issues. These were more complex than the test I wrote for the first part of 0.3 so  I saw it as a good opportunity to improve my skill. I asked in Slack for some advice on what to do and was given this idea from David: This seemed like a good test to write (challenging but something I can figure out) so I made an issue for it and started working! When I first wrote the test everything looked fine but it kept on failing. At first, I thought that's good, if we pass an invalid date shouldn't the test fa
Read more