OSD600 Release 0.2 PR 3

 We are in the third week of Hacktoberfest and it is getting exciting! This week I decided to work on this issue. They needed someone to add Chateau d'Ax to the name suggestion index. When I first saw this I very nervous as I had no idea how to do it. But it is PR 3, we are halfway done the course, it's time to start taking some risks! So I decided to stop worrying and just "jump in". This approach really paid off! After I let the maintainers know I wan to work on this issue I forked the repo, made a new branch, and cloned to my local machine. I reread the issue, took some time to think about, and started looking at the files that needed to be modified. I noticed I needed to modify a file in the data/brands/shop folder (furniture.json). Adding the data wasn't so bad, the hardest part about this issue was finding the information to add. Most of the information was given in the issue:

When adding the country codes there were some I could not find in the wiki the provided, I also could not find a wiki for Chateau d'Ax so I did what I can, then showed what I have done and asked for some clarification. I have learned when working on Open Source it's better/easier to ask for help than just guess, we have a community, so take advantage! They were very nice and helped me out: 
I then took their feedback, fixed my code, and made a PR. A couple of days after, my code got merged! Out of all the pull requests I have done this semester, this one makes me the proudest of myself. I finally stopped worrying (Something all my friends, family and professors have been telling me to do 😀) Did something out of my comfort zone, and most importantly learned something new. It has only been half a semester and I have learned some much, I can't wait for the second half to learn more! 



 

Comments

Post a Comment

Popular posts from this blog

OSD600 Release 0.4 Part 3

Image
 This is the last blog for OSD600 and the last part of release 0.4! I am excited to be writing this as after this I will be done with everything I need to do for my classes this semester, and graduate! One issue I noticed while working on this is I did not fully understand what was needed to "port" a component from Gatsby to Next. At first, I thought everything you needed to do to port a component was in this migration guide  posted in the issue . After talking to some people on Slack I learned we must not only follow the migration guide but also convert the JavaScript code in the components to TypeScript. I have worked with Typescript before so I had an idea of how it works/what it is (it's basically JavaScript with types), but I never knew how to convert JavaScript code to TypeScript code. After doing some research I learned this process can be broken down into two simple steps: 1. Change all the .jsx files to .tsx files. 2. Add types to all the variables made. Eg. func
Read more

OSD600 Lab 5

Image
 This week we learned about rebasing in Git! Rebasing is basically taking multiple commits and "grouping" or "moving" them into one commit. Before I started the lab I did the walkthrough on the OSD600 GitHub Wiki. At first, I struggled with it (kept getting errors when running git rebase master -i). Then I decided to start over again and I noticed the first time I forgot to commit some files on the refactor branch. I am happy I did this first because it made the lab go very smoothly.  Before I started the lab I took a look at my code and wrote down the improvements I was planning to make. I decided to do these 3 things: change my regular expression variable from a let to a const, remove an array I never used, and update some functions to use the ES6 arrow syntax. It's been a while since I used arrow functions so I used this resource to guide me Every time I added and tested a feature I did a git commit. One improvement that caused an error was when I updated som
Read more

Release 0.3 PR2

Image
  For release 3 we have to make 2 PR's. The first one must be for the  Telesope project  and the second one must be for an external project. These PR's must "build up" from the PR's we did for release 0.2. This blog post will highlight working on the PR for Telescope. When I started this the first place I went was to the issues page on the Telescope repository. I saw there were some tests that needed to be written and were interested in taking on one of these issues. These were more complex than the test I wrote for the first part of 0.3 so  I saw it as a good opportunity to improve my skill. I asked in Slack for some advice on what to do and was given this idea from David: This seemed like a good test to write (challenging but something I can figure out) so I made an issue for it and started working! When I first wrote the test everything looked fine but it kept on failing. At first, I thought that's good, if we pass an invalid date shouldn't the test fa
Read more